Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SaltProviderNext stable #3714

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

origami-z
Copy link
Contributor

Copy link

changeset-bot bot commented Jul 4, 2024

🦋 Changeset detected

Latest commit: f26b00d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 1:51pm

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

github-actions bot commented Jul 8, 2024

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@origami-z
Copy link
Contributor Author

0.0.0-snapshot-20240708114405

Tested with sample app with backwards compatibility. Works fine

bhoppers2008
bhoppers2008 previously approved these changes Jul 8, 2024
@origami-z origami-z force-pushed the 3536-stable-theme-next-provider branch from f642697 to ed2ff8b Compare July 8, 2024 16:05
@pseys pseys self-requested a review July 8, 2024 19:52
Copy link
Contributor

@pseys pseys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the Kitchen Sink examples all text links seem to have the wrong cursor behaviour on hover. Is this an issue within the code of the kitchen sink or an issue with Theme Next?

@origami-z
Copy link
Contributor Author

In the Kitchen Sink examples all text links seem to have the wrong cursor behaviour on hover. Is this an issue within the code of the kitchen sink or an issue with Theme Next?

Couldn't find a difference between 2 themes. What do you see?

@pseys
Copy link
Contributor

pseys commented Jul 9, 2024

In the Kitchen Sink examples all text links seem to have the wrong cursor behaviour on hover. Is this an issue within the code of the kitchen sink or an issue with Theme Next?

Couldn't find a difference between 2 themes. What do you see?

The link component shows a pointer whereas kitchen sink shows a text cursor.

@origami-z origami-z force-pushed the 3536-stable-theme-next-provider branch from 998bd07 to f26b00d Compare July 9, 2024 13:46
@joshwooding joshwooding merged commit 9abf267 into main Jul 9, 2024
15 checks passed
@joshwooding joshwooding deleted the 3536-stable-theme-next-provider branch July 9, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants