-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combo box different selection and clear behaviour #3785
Comments
On this bullet "If there was a selection before, clear filter string and revert to previous selection"... i find it unexpected that an 'Esc' key press doesn't revert to previous selection at any point (even if all characters have been removed from the field). This bullet is very similar to bullet 4... If speed is essential than i can see a benefit. Not sure it should be default behaviour though. |
Interaction specs are done and to be reviewed, details & links in teams group chat.
|
Cortado Goal: Design to present their findings and new ticket to implement in Doppio |
Cortado Goal: create tickets for each example and label "help wanted" |
Area
UI Components
The problem
Currently following is combo box behavior
If user select any option then they have to erase complete text or most part of the text to show complete list and update option.
If user adds some text and then move out and then focus inside it wont show the selected option and something wont show options to user(If previous entered text doesn't match with options).
The solution
It is good to have following things:
Show all option on focus
Show filtered selected option when user types
Clearing filter string if no selection is made
If there was no selection earlier, show blank
If there was a selection before, clear filter string and revert to previous selection
Clear selection if filter string is made blank by user.(done insalt-ds/packages/core/src/combo-box/ComboBox.tsx
Lines 311 to 313 in e8d923c
Alternatives and examples
https://codesandbox.io/p/sandbox/react-hook-form-salt-combobox-y2nd96
Are you a JPMorgan Chase & Co. employee?
The text was updated successfully, but these errors were encountered: