Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ComboBox - Clearing filter string #3953

Open
mark-tate opened this issue Aug 6, 2024 · 1 comment
Open

ComboBox - Clearing filter string #3953

mark-tate opened this issue Aug 6, 2024 · 1 comment
Labels
component: combo box status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request

Comments

@mark-tate
Copy link
Contributor

mark-tate commented Aug 6, 2024 •
edited by joshwooding
Loading

Created from #3785

Update ComboBox to have the following behaviour:

If there was no selection earlier, show blank

If there was a selection before, clear filter string and revert to previous selection
@mark-tate mark-tate converted this from a draft issue Aug 6, 2024
@mark-tate mark-tate mentioned this issue Aug 6, 2024
Closed
1 task
@joshwooding
Copy link
Contributor

After discussing with a11y, we believe this should not be the default behaviour but will investigate providing an example or adding a prop to enable this behaviour.

@joshwooding joshwooding added status: waiting for 👍 Waiting for upvotes to gauge interest type: enhancement 💡 New feature or request status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. and removed status: waiting for 👍 Waiting for upvotes to gauge interest labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: combo box status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mark-tate @joshwooding