Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'legacy' theme variables to Salt Styles Library in Figma #3846

Closed
6 tasks done
pseys opened this issue Jul 18, 2024 · 10 comments
Closed
6 tasks done

Add 'legacy' theme variables to Salt Styles Library in Figma #3846

pseys opened this issue Jul 18, 2024 · 10 comments

Comments

@pseys
Copy link
Contributor

pseys commented Jul 18, 2024

Connect legacy palette variables to characteristics within the Salt Next Styles Library.

Considerations

  • The characteristic variables will need modes applied; Salt Next and Salt Legacy (TBC)
  • Each characteristic variable mode will need to be mapped to a different set of palette variables – the Salt Next characteristics are already aligned to Accent / Mode in the styles library. Salt Legacy will need to map to a 'Mode' only switch, either in the same file or from a different library (TBC)
  • When creating a new design, components will default to Salt Next, but designers will have the ability to toggle to Salt Legacy if they wish, however, they will have to set mode separately

Dependent on #3843 and #3844

@pseys pseys converted this from a draft issue Jul 18, 2024
@pseys pseys changed the title Connect legacy palette variables to characteristics within the Salt Next Styles Library Connect legacy palette variables to characteristics in Figma Jul 18, 2024
@pseys pseys self-assigned this Jul 18, 2024
@mark-tate
Copy link
Contributor

Espresso Goal : write up the approach and share with Stakeholders and get feedback

@mark-tate
Copy link
Contributor

mark-tate commented Sep 13, 2024

Frappe Goal: write up the approach and share with Stakeholders and get feedback

  • how do we refer to the themes
  • how much we restrict the use of theme next styling options with the legacy theme

@mark-tate
Copy link
Contributor

poc working - getting feedback

@mark-tate
Copy link
Contributor

Revised Frappe Goal: get all color variables in place by EOS with no carryover ,
Next Sprint: report back on strategy and agree approach based on stakeholder feedback

@mark-tate
Copy link
Contributor

Galao Goal: agree on the direction and create smaller tasks by end of wk1

@pseys
Copy link
Contributor Author

pseys commented Oct 3, 2024

Changing name of issue from to Connect legacy palette variables to characteristics in Figma Add 'legacy' theme variables to Salt Styles Library in Figma

@pseys pseys changed the title Connect legacy palette variables to characteristics in Figma Add 'legacy' theme variables to Salt Styles Library in Figma Oct 3, 2024
@pseys
Copy link
Contributor Author

pseys commented Oct 3, 2024

Successfully separated Accent from Mode as part of the POC

@pseys
Copy link
Contributor Author

pseys commented Oct 3, 2024

Galao Goal: agree on the direction and create smaller tasks by end of wk1

Next steps have been broken out as smaller sub-tasks and progressed updated.

@pseys
Copy link
Contributor Author

pseys commented Oct 11, 2024

The Brine POC has been successful. Next steps have been created as new issues.

@pseys
Copy link
Contributor Author

pseys commented Oct 11, 2024

Initial POC complete

@pseys pseys closed this as completed Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants