Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vertical Navigation examples #3276

Merged
merged 16 commits into from
May 3, 2024
Merged

Vertical Navigation examples #3276

merged 16 commits into from
May 3, 2024

Conversation

lilyvc
Copy link
Contributor

@lilyvc lilyvc commented Apr 23, 2024 •
edited
Loading

This PR adds two vertical navigation examples to the patterns section in storybook

  • Single level
  • Nested

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 2ead22d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 3, 2024 0:59am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 23, 2024 •
edited
Loading

Storybook Preview Link https://a706be2b.saltdesignsystem-storybook.pages.dev

@lilyvc lilyvc changed the title Vertical Navigation example Vertical Navigation examples Apr 23, 2024
Fercas123
Fercas123 previously approved these changes Apr 24, 2024
View reviewed changes
origami-z
origami-z reviewed Apr 25, 2024
View reviewed changes
Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add link from pattern to storybook?

origami-z
origami-z reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably need a team discussion on the use of style in our examples, which ones are ok v.s. others are showing limitation of the component which we need to fix

packages/core/stories/patterns/vertical-navigation/vertical-navigation.stories.tsx Outdated Show resolved Hide resolved
packages/core/stories/patterns/vertical-navigation/vertical-navigation.stories.tsx Outdated Show resolved Hide resolved
@lilyvc lilyvc merged commit e15cdc4 into main May 3, 2024
15 checks passed
@lilyvc lilyvc deleted the vertical-navigation-example branch May 3, 2024 13:19
JoanaMMoreira pushed a commit that referenced this pull request May 8, 2024
@lilyvc @JoanaMMoreira
Vertical Navigation examples (#3276)
4ed7ab4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fercas123 Fercas123 Fercas123 approved these changes

@origami-z origami-z origami-z approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lilyvc @origami-z @Fercas123