Slider Cypress / QA Tests #3353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
lukeac123
commented
May 2, 2024
| .parent() | ||
| .trigger("mousemove", { clientX: 50, clientY: 50 }); | ||
| cy.get("@changeSpy").should("have.callCount", 2); | ||
| }); |
There was a problem hiding this comment.
This and the above test check to see if the onChange is fired but don't check to validate the thumb has move the appropriate value that the mouse position corresponds to. Any ideas on how to do this ?
One possibility could be to separately unit test the individual calculations ?
Or is this sufficient for now?
|
Storybook Preview Link https://e9ec682d.saltdesignsystem-storybook.pages.dev |
|
@lukeac123 Should this just be merged into #3296? Tests arguably should be delivered with the code |
lukeac123
added a commit
that referenced
this pull request
May 29, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Jun 13, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Jun 19, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Jul 1, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Jul 23, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Jul 23, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Jul 25, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Jul 30, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
tomhazledine
pushed a commit
that referenced
this pull request
Aug 8, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
joshwooding
pushed a commit
that referenced
this pull request
Sep 5, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
joshwooding
pushed a commit
that referenced
this pull request
Sep 10, 2024
input example + aria label types and refactor prettier self review + cs update tooltip css typedocs + change label prop to marks Slider Cypress / QA Tests (#3353) [WIP] Slider range (#3451) validation example update cs prettier + qa tests prevent default update mouse to pointer fix types type error explaination for type issue range slider cypress tests prettier typo update thumb tooltip behaviour
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.