Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme next heading font switch #3396

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

origami-z
Copy link
Contributor

Depends on #3391, review additional commits only

This serves initial feature support for font switching capability, but doesn't not include

  • Upload Amplitude to storybook to be used (pending license discussion)
  • Detailed doc on how to install Amplitude in an app, e.g., font face declaration for all font weight
  • New display 4 text
  • New display family size remapping in theme next
  • Amplitude font weight remapping (medium v.s. Open Sans semi bold)

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 16, 2024 7:45am

Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: e8ec91a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/core Minor
@salt-ds/theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented May 9, 2024

Storybook Preview Link https://67971b43.saltdesignsystem-storybook.pages.dev

@origami-z origami-z force-pushed the theme-next-heading-font-switch branch from ef60f4c to 8415c76 Compare May 13, 2024 19:02
@origami-z origami-z force-pushed the theme-next-heading-font-switch branch 2 times, most recently from d28440f to 149083e Compare May 14, 2024 19:10
@joshwooding joshwooding merged commit e1d4aab into main May 16, 2024
15 checks passed
@joshwooding joshwooding deleted the theme-next-heading-font-switch branch May 16, 2024 09:34
libertymayc pushed a commit that referenced this pull request May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants