Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add selectOnTab to ComboBox #3399

Merged
merged 1 commit into from
Jun 11, 2024
Merged

Add selectOnTab to ComboBox #3399

merged 1 commit into from
Jun 11, 2024

Conversation

ThusharaJ07
Copy link
Contributor

@ThusharaJ07 ThusharaJ07 commented May 10, 2024 •
edited by origami-z
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 3ed33b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented May 10, 2024

@ThusharaJ07 is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@vercel Vercel
Copy link

vercel bot commented May 10, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 10, 2024 8:11pm

@joshwooding joshwooding marked this pull request as draft May 29, 2024 09:31
bhoppers2008
bhoppers2008 previously approved these changes May 30, 2024
View reviewed changes
@origami-z origami-z changed the title combobox select on blur combobox select on blur tabToSelect May 30, 2024
origami-z
origami-z previously approved these changes May 31, 2024
View reviewed changes
@origami-z origami-z marked this pull request as ready for review June 5, 2024 11:31
@joshwooding joshwooding marked this pull request as draft June 5, 2024 14:00
@joshwooding
Copy link
Contributor

Moved to draft due to conflicts

@joshwooding
Copy link
Contributor

Just found a bug that when you tab when the combobox is closed the selection is still made

@ThusharaJ07 ThusharaJ07 marked this pull request as ready for review June 7, 2024 10:03
bhoppers2008
bhoppers2008 previously approved these changes Jun 10, 2024
View reviewed changes
origami-z
origami-z previously approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last bug fixed and covered in test. Good to go.

joshwooding
joshwooding requested changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@joshwooding joshwooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs some minor updates

@joshwooding joshwooding dismissed stale reviews from origami-z and bhoppers2008 via 1030b86 June 10, 2024 14:32
@joshwooding joshwooding marked this pull request as draft June 10, 2024 15:14
@joshwooding
Copy link
Contributor

Moving to draft temporarily, can be moved out after #3537

@joshwooding joshwooding force-pushed the comobox-select-on-blur branch from 1030b86 to 3ed33b9 Compare June 10, 2024 19:30
@joshwooding joshwooding marked this pull request as ready for review June 10, 2024 20:06
@joshwooding joshwooding changed the title combobox select on blur tabToSelect Add selectOnTab to ComboBox Jun 10, 2024
@origami-z origami-z merged commit a89efd2 into jpmorganchase:main Jun 11, 2024
16 checks passed
@origami-z origami-z mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mark-tate mark-tate mark-tate left review comments

@joshwooding joshwooding joshwooding approved these changes

@origami-z origami-z origami-z approved these changes

@bhoppers2008 bhoppers2008 bhoppers2008 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ThusharaJ07 @joshwooding @mark-tate @origami-z @bhoppers2008