Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add status bold and content foreground bold tokens #3609

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Jun 20, 2024

To verify, use Storybook, go to /?path=/docs/theme-characteristics-status--docs and toggle between theme and theme next

I only did bare minimum in storybook, for us to confirm tokens in theme and theme next, given we don't have other mechanism to see them.

Part of #3535

Copy link

vercel bot commented Jun 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 28, 2024 3:27pm

Copy link

changeset-bot bot commented Jun 20, 2024

🦋 Changeset detected

Latest commit: 5cdf570

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@origami-z origami-z force-pushed the add-status-bold-bg-tokens branch from 9a47bc5 to f731417 Compare June 21, 2024 10:27
@origami-z origami-z requested a review from pseys June 26, 2024 19:55
@origami-z origami-z force-pushed the add-status-bold-bg-tokens branch from f731417 to 393dce5 Compare June 28, 2024 10:58
@origami-z origami-z changed the title Add status bold tokens Add status bold and content foreground bold tokens Jun 28, 2024
@origami-z origami-z marked this pull request as ready for review June 28, 2024 11:06
@origami-z origami-z force-pushed the add-status-bold-bg-tokens branch from 393dce5 to 76e547e Compare June 28, 2024 11:57
@joshwooding joshwooding force-pushed the add-status-bold-bg-tokens branch from 76e547e to 5cdf570 Compare June 28, 2024 15:22
@joshwooding joshwooding merged commit fc60301 into main Jun 28, 2024
15 checks passed
@joshwooding joshwooding deleted the add-status-bold-bg-tokens branch June 28, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants