Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various ag grid theme fixes #3822

Merged
merged 8 commits into from
Jul 22, 2024
Merged

Various ag grid theme fixes #3822

merged 8 commits into from
Jul 22, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Jul 15, 2024

  • Adds custom dropdown editor example
  • Adds custom flag renderer example
  • Ag Menu padding to match Salt menu (0 padding)
  • Group cell line height mismatch
  • Custom cell editor background color when focused (should be black in dark, instead of blue)
  • Double focus ring for a custom dropdown editor
  • Changed base size implementation in HD Compact

#3775, #3675

Design related task to support HD compact in Figma Next: #3850

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 22, 2024 3:05pm

Copy link

changeset-bot bot commented Jul 15, 2024

🦋 Changeset detected

Latest commit: 261571c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/ag-grid-theme Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @salt-ds/[email protected]

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@origami-z origami-z force-pushed the 3775-ag-grid-theme-hd-issues branch from a0d2acc to 0c10922 Compare July 18, 2024 11:44
@origami-z origami-z marked this pull request as ready for review July 18, 2024 14:31
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 18, 2024
@origami-z origami-z requested a review from bhoppers2008 July 18, 2024 14:32
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 18, 2024
@origami-z origami-z force-pushed the 3775-ag-grid-theme-hd-issues branch from d178779 to d91046b Compare July 19, 2024 09:14
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 19, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 19, 2024
@origami-z
Copy link
Contributor Author

/release-pr

Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshots have been published to npm.

Test the snapshots by updating your package.json with the newly published versions:

yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]
yarn add @salt-ds/[email protected]

@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 20, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 20, 2024
@origami-z origami-z changed the title Various ag grid theme changes Various ag grid theme fixes Jul 22, 2024
@origami-z origami-z force-pushed the 3775-ag-grid-theme-hd-issues branch from f06a626 to b7f8735 Compare July 22, 2024 14:18
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 22, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 22, 2024
@joshwooding joshwooding force-pushed the 3775-ag-grid-theme-hd-issues branch from b7f8735 to 261571c Compare July 22, 2024 15:00
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 22, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Jul 22, 2024
@origami-z origami-z merged commit d92fe9e into main Jul 22, 2024
15 of 16 checks passed
@origami-z origami-z deleted the 3775-ag-grid-theme-hd-issues branch July 22, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants