Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add controlled Accordion example #3992

Merged
merged 3 commits into from
Sep 11, 2024
Merged

Add controlled Accordion example #3992

merged 3 commits into from
Sep 11, 2024

Conversation

liamsms
Copy link
Contributor

@liamsms liamsms commented Aug 15, 2024

Closes #3965

  • Added a controlled Accordion example which includes the expand all and collapse all buttons.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a3b1126

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Aug 15, 2024

@liamsms is attempting to deploy a commit to the FED Team Team on Vercel.

A member of the Team first needs to authorize it.

@joshwooding joshwooding added the CLA: Received CLA has been received label Sep 11, 2024
@joshwooding joshwooding force-pushed the add-accordion-controlled-example branch from f5ed676 to e9255c5 Compare September 11, 2024 14:19
@vercel Vercel
Copy link

vercel bot commented Sep 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 2:37pm

@joshwooding joshwooding force-pushed the add-accordion-controlled-example branch from e9255c5 to b45c3c1 Compare September 11, 2024 14:27
@joshwooding joshwooding force-pushed the add-accordion-controlled-example branch from b45c3c1 to a3b1126 Compare September 11, 2024 14:28
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 11, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Sep 11, 2024
@joshwooding joshwooding merged commit eb146e3 into jpmorganchase:main Sep 11, 2024
16 checks passed
@joshwooding
Copy link
Contributor

Thanks @liamsms

@liamsms liamsms deleted the add-accordion-controlled-example branch September 11, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshwooding joshwooding joshwooding approved these changes

@DavieReid DavieReid DavieReid approved these changes

@tomhazledine tomhazledine tomhazledine approved these changes

Assignees
No one assigned
Labels
CLA: Received CLA has been received
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add an example of an expand and collapse all button for accordions
4 participants
@liamsms @joshwooding @tomhazledine @DavieReid