Add Card Content component #4101
Draft
+135
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ea74d7c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
joshwooding
commented
Sep 13, 2024
joshwooding
commented
Sep 13, 2024
packages/core/src/card/Card.tsx
Outdated
| const cardRef = useRef<HTMLDivElement | null>(null); | ||
| const handleRef = useForkRef(cardRef, ref); | ||
|
|
||
| useLayoutEffect(() => { |
There was a problem hiding this comment.
Need to update this
packages/core/src/card/Card.tsx
Outdated
| const observer = new MutationObserver((mutations) => { | ||
| for (const mutation of mutations) { | ||
| for (const addedNode of mutation.addedNodes) { | ||
| console.log(addedNode); |
There was a problem hiding this comment.
Is the aim here to make it so that if there's no children (subtree false? childList false?), add the noContentComponent class suffix?
There was a problem hiding this comment.
Yeah, this was really just to show the poc
joshwooding
force-pushed
the
add-card-content-component
branch
from
64823c3 to
1bc7688
Compare
joshwooding
force-pushed
the
add-card-content-component
branch
from
1bc7688 to
ea74d7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long overdue, but had some spare time to create something quickly.
Decisions: