Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ag grid v32 support #4276

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Add ag grid v32 support #4276

merged 6 commits into from
Nov 19, 2024

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Oct 8, 2024 •
edited
Loading

On top of #4257

Upgrade to v32 to support

  • New active filter icon style
  • New default menu style (not tabbed menu), see doc

Todos

  • filter icon active state (both in floating filter and column header cell), when filter is active, need to show some visual indicator (e.g. ag grid examples shows a light blue background and dot badge). In this PR, it's implemented match closely to Salt toggle button active state. Ag grid v32 floating filter active state #4275
  • filter panel apply (blue) / reset (gray) button, changed from ref attribute to data-ref.
  • header sort icon should be next to filter / menu icon
    • double check v31 regression
  • checkbox column (e.g. context menu story) shouldn't have filter
  • context menu size larger due to ag-size change
  • mention suppressMenuHide Customising the Column Menu added to one site example

Snapshot test on StackBlitz

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 8, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 8e09eeb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@salt-ds/ag-grid-theme Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Oct 8, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 9:31am

@origami-z
Copy link
Contributor Author

/release-pr

@github-actions GitHub Actions
Copy link
Contributor

🫰✨ Thanks @origami-z! Your snapshot has been published to npm.

Test the snapshot by updating your package.json with the newly published version:

yarn add @salt-ds/[email protected]

@origami-z origami-z mentioned this pull request Oct 14, 2024
Merged
12 tasks
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 23, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Oct 23, 2024
@origami-z origami-z mentioned this pull request Oct 23, 2024
Closed
bhoppers2008
bhoppers2008 previously approved these changes Nov 15, 2024
View reviewed changes
@origami-z origami-z added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 15, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 15, 2024
joshwooding
joshwooding reviewed Nov 18, 2024
View reviewed changes
yarn.lock Outdated Show resolved Hide resolved
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 18, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 18, 2024
@origami-z
Ag grid v32 support
b1e4e66 
- Add floating filter active button support
- Add ag grid to peerDep
- Add button hover states
- Update menu padding, select border.
- Update example column defs with new suppress options
- Change filter icon to clear vs filled
- Fix focus style for header cell
- Add v32 in site doc
@origami-z
Update fake button box shadow size
fb1be54
@origami-z
Update changeset
976fa64
@origami-z
Revert back active filter toggle button style
d5f6a62
@origami-z
Fixes button focus changes size
06f34fe
@origami-z
dedupe lock
8e09eeb
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 19, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 19, 2024
@origami-z origami-z merged commit b4a7888 into main Nov 19, 2024
15 checks passed
@origami-z origami-z deleted the 4275-ag-grid-v32 branch November 19, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhoppers2008 bhoppers2008 bhoppers2008 approved these changes

@Fercas123 Fercas123 Fercas123 approved these changes

@joshwooding joshwooding joshwooding approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@origami-z @joshwooding @Fercas123 @bhoppers2008