Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New header for overlay #4282

Merged
merged 19 commits into from
Nov 19, 2024
Merged

New header for overlay #4282

merged 19 commits into from
Nov 19, 2024

Conversation

Fercas123
Copy link
Contributor

Adds new OverlayHeader component to replace deprecated OverlayPanelCloseButton

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: dbf7191

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@salt-ds/lab Minor
@salt-ds/data-grid Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 2:35pm

@Fercas123
Copy link
Contributor Author

needs an example to showcase header usage on site

origami-z
origami-z previously approved these changes Oct 15, 2024
Copy link
Contributor

@origami-z origami-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably fine for a lab component. I'm still a little confused about the what's changed around header block vs existing solution in core, maybe worth to document some visual changes later.

packages/lab/stories/overlay/overlay.stories.tsx Outdated Show resolved Hide resolved
packages/lab/stories/overlay/overlay.stories.tsx Outdated Show resolved Hide resolved
packages/lab/stories/overlay/overlay.stories.tsx Outdated Show resolved Hide resolved
packages/lab/src/overlay/OverlayHeader.tsx Show resolved Hide resolved
packages/lab/src/overlay/OverlayHeader.tsx Outdated Show resolved Hide resolved
origami-z
origami-z previously approved these changes Nov 18, 2024
.changeset/quiet-rice-prove.md Outdated Show resolved Hide resolved
@Fercas123 Fercas123 added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 19, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 19, 2024
@Fercas123 Fercas123 added chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. and removed chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. labels Nov 19, 2024
@joshwooding joshwooding added the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 19, 2024
@github-actions github-actions bot removed the chromatic Run chromatic on the current PR. Will be removed by the CI once submitted. label Nov 19, 2024
@Fercas123 Fercas123 merged commit e7b0406 into main Nov 19, 2024
14 of 15 checks passed
@Fercas123 Fercas123 deleted the overlay-header branch November 19, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants