You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Thank you for putting the page and examples together, @joshwooding ! I left a few comments in the review but adding more general comments here:
Font weight in the images is still looking bold. I know we already chatted about it but just adding for awareness. LMK if the re-exported images I sent in teams prevent this issue.
Also, let me know your recommendations about using spinner in the images instead of progress, until the small circular progress is available in design and code. On my end, I think it is OK considering we will have the small circular progress available in Q4. But dev wisdom is very welcome.
Thank you for putting the page and examples together, @joshwooding ! I left a few comments in the review but adding more general comments here:
Font weight in the images is still looking bold. I know we already chatted about it but just adding for awareness. LMK if the re-exported images I sent in teams prevent this issue.
Also, let me know your recommendations about using spinner in the images instead of progress, until the small circular progress is available in design and code. On my end, I think it is OK considering we will have the small circular progress available in Q4. But dev wisdom is very welcome.
I haven't re-exported the images yet but it should fix it.
The problem with using small circular progress will be that teams will want to use it. If we are going to we should add a disclaimer that we can remove in the future
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
joshwooding
force-pushed
the
add-file-upload-pattern
branch
from
github-actions
bot
removed
the
chromatic
No description provided.