Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add known dropdown a11y issue #4379

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

origami-z
Copy link
Contributor

@origami-z origami-z commented Nov 4, 2024

Copy link

changeset-bot bot commented Nov 4, 2024

⚠️ No Changeset found

Latest commit: acad98f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
saltdesignsystem ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 17, 2024 7:12pm

@jake-costa
Copy link

Hi @origami-z @joshwooding Confirmed this is no longer an issue on MacOS 15.1.

Can you update the issue details to
OS: MacOS 14

And for Recommendations:
add Update to MacOS 15.1+

Then we can close this and #3490

@origami-z
Copy link
Contributor Author

Hi @origami-z @joshwooding Confirmed this is no longer an issue on MacOS 15.1.

Can you update the issue details to OS: MacOS 14

And for Recommendations: add Update to MacOS 15.1+

Then we can close this and #3490

Updated

@@ -8,6 +8,49 @@ data:
$ref: ./#/data
---

## Known accessibility issue
Copy link
Contributor

@joshwooding joshwooding Nov 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this should be on the combobox page too @jake-costa ? Or is it only dropdowns?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshwooding Since combobox is also using role="listbox" the info should probably go on both however the workaround isn't working for me on Combobox.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshwooding Also, maybe rename "Known issues" to "Accessibility considerations"?

Copy link
Contributor Author

@origami-z origami-z Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to update the doc if needed

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jake-costa Could you prepare a page for the ComboBox too then, or should we not provide a workaround?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshwooding Sure, but I think we can use a lot of what you have already. Like you mentioned we would just remove the workaround. The only change would be to change the first use of "APG" to "ARIA Authoring Practices Guide (APG)"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshwooding Updated the docs for CombBox and Dropdown. Let me know what you think.

Copy link

@jake-costa jake-costa Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joshwooding also what are your thoughts on moving the "Accessibility considerations" section under the keyboard interactions?

I think it makes sense to have primary accessibility information like screen reader expectations and keyboard interactions first then any known issues after as secondary, but what are your thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants