-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add known dropdown a11y issue #4379
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Hi @origami-z @joshwooding Confirmed this is no longer an issue on MacOS 15.1. Can you update the issue details to And for Recommendations: Then we can close this and #3490 |
Updated |
@@ -8,6 +8,49 @@ data: | |||
$ref: ./#/data | |||
--- | |||
|
|||
## Known accessibility issue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm guessing this should be on the combobox page too @jake-costa ? Or is it only dropdowns?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshwooding Since combobox is also using role="listbox" the info should probably go on both however the workaround isn't working for me on Combobox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshwooding Also, maybe rename "Known issues" to "Accessibility considerations"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to update the doc if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jake-costa Could you prepare a page for the ComboBox too then, or should we not provide a workaround?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshwooding Sure, but I think we can use a lot of what you have already. Like you mentioned we would just remove the workaround. The only change would be to change the first use of "APG" to "ARIA Authoring Practices Guide (APG)"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshwooding Updated the docs for CombBox and Dropdown. Let me know what you think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@joshwooding also what are your thoughts on moving the "Accessibility considerations" section under the keyboard interactions?
I think it makes sense to have primary accessibility information like screen reader expectations and keyboard interactions first then any known issues after as secondary, but what are your thoughts?
preview page: https://saltdesignsystem-git-3490-dropdown-safari-known-75de3d-fed-team.vercel.app/salt/components/dropdown/accessibility
#3490