Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghost first try #4464

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+442 −1
Draft

ghost first try #4464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c9bdc8
ghost first try
Fercas123 Nov 29, 2024
1729fa4
ghost first try, comments
Fercas123 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
204 changes: 204 additions & 0 deletions packages/core/stories/ghost-button/ghost-button.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,204 @@
import { Banner, Button, FlowLayout, StackLayout } from "@salt-ds/core";
import { CloseIcon, SearchIcon } from "@salt-ds/icons";
import { GhostButton, SystemStatus } from "@salt-ds/lab";
import type { Meta, StoryFn } from "@storybook/react";

export default {
title: "Lab/GhostButton",
component: GhostButton,
argTypes: { onClick: { action: "clicked" } },
} as Meta<typeof GhostButton>;

export const TestingEverything: StoryFn<typeof GhostButton> = (props) => {
return (
<StackLayout>
<div style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
<Button appearance="transparent">
<CloseIcon aria-hidden /> Button
</Button>
</div>
<Banner status="success" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<Banner status="error" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<Banner status="info" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<Banner status="warning" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<Banner variant="secondary" status="success" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<Banner variant="secondary" status="error" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<Banner variant="secondary" status="info" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<Banner variant="secondary" status="warning" style={{ width: 500 }}>
<GhostButton aria-label="Search" {...props}>
<CloseIcon aria-hidden /> Button
</GhostButton>
</Banner>
<div style={{ width: 500 }}>
<GhostButton
adaptiveAppearance="solid"
disabled
aria-label="Search"
{...props}
>
<CloseIcon aria-hidden /> Button
</GhostButton>
</div>
<SystemStatus status="success" style={{ width: 500 }}>
<GhostButton adaptiveAppearance="solid">
<SearchIcon aria-hidden /> Search
</GhostButton>
</SystemStatus>
<SystemStatus status="error" style={{ width: 500 }}>
<GhostButton adaptiveAppearance="solid">
<SearchIcon aria-hidden /> Search
</GhostButton>
</SystemStatus>
<SystemStatus status="info" style={{ width: 500 }}>
<GhostButton adaptiveAppearance="solid">
<SearchIcon aria-hidden /> Search
</GhostButton>
</SystemStatus>
<SystemStatus status="warning" style={{ width: 500 }}>
<GhostButton adaptiveAppearance="solid">
<SearchIcon aria-hidden /> Search
</GhostButton>
</SystemStatus>
</StackLayout>
);
};

const ButtonGridTemplate: StoryFn<typeof GhostButton> = (props) => {
return (
<FlowLayout>
<GhostButton {...props}>Submit</GhostButton>
<GhostButton aria-label="Search" {...props}>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton {...props}>
<SearchIcon aria-hidden /> Search
</GhostButton>
<Banner status="info">
<GhostButton {...props}>Submit</GhostButton>
<GhostButton aria-label="Search" {...props}>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton {...props}>
<SearchIcon aria-hidden /> Search
</GhostButton>
</Banner>
<SystemStatus status="info">
<GhostButton {...props}>Submit</GhostButton>
<GhostButton aria-label="Search" {...props}>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton {...props}>
<SearchIcon aria-hidden /> Search
</GhostButton>
</SystemStatus>
</FlowLayout>
);
};

export const Disabled: StoryFn = (props) => {
return (
<StackLayout gap={3}>
<FlowLayout>
<GhostButton disabled>Submit</GhostButton>
<GhostButton aria-label="Search" disabled>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton disabled>
<SearchIcon aria-hidden /> Search
</GhostButton>
<Banner status="info">
<GhostButton disabled>Submit</GhostButton>
<GhostButton aria-label="Search" disabled>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton disabled>
<SearchIcon aria-hidden /> Search
</GhostButton>
</Banner>
<SystemStatus status="info">
<GhostButton disabled>Submit</GhostButton>
<GhostButton aria-label="Search" disabled>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton disabled>
<SearchIcon aria-hidden /> Search
</GhostButton>
</SystemStatus>
</FlowLayout>
<FlowLayout>
<GhostButton adaptiveAppearance="solid" disabled>
Submit
</GhostButton>
<GhostButton adaptiveAppearance="solid" aria-label="Search" disabled>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton adaptiveAppearance="solid" disabled>
<SearchIcon aria-hidden /> Search
</GhostButton>
<Banner status="info">
<GhostButton adaptiveAppearance="solid" disabled>
Submit
</GhostButton>
<GhostButton adaptiveAppearance="solid" aria-label="Search" disabled>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton adaptiveAppearance="solid" disabled>
<SearchIcon aria-hidden /> Search
</GhostButton>
</Banner>
<SystemStatus status="info">
<GhostButton adaptiveAppearance="solid" disabled>
Submit
</GhostButton>
<GhostButton adaptiveAppearance="solid" aria-label="Search" disabled>
<SearchIcon aria-hidden />
</GhostButton>
<GhostButton adaptiveAppearance="solid" disabled>
<SearchIcon aria-hidden /> Search
</GhostButton>
</SystemStatus>
</FlowLayout>
</StackLayout>
);
};

export const Solid = ButtonGridTemplate.bind({});
Solid.args = {
adaptiveAppearance: "solid",
};

export const NonSolid = ButtonGridTemplate.bind({});
NonSolid.args = {
adaptiveAppearance: "non-solid",
};
151 changes: 151 additions & 0 deletions packages/lab/src/ghost-button/GhostButton.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,151 @@
/* TODO: sort and rename*/

.salt-theme.salt-theme-next[data-mode="light"] {
/* added the below token, needs renaming*/
--salt-palette-alpha-weaky: var(--salt-color-black-20a);

--salt-palette-alpha-hover-alt: var(--salt-color-black-10a);
--salt-palette-alpha-active-alt: var(--salt-color-black-20a);
}
.salt-theme.salt-theme-next[data-mode="dark"] {
/* added the below token, needs renaming*/
--salt-palette-alpha-weaky: var(--salt-color-white-20a);

--salt-palette-alpha-hover-alt: var(--salt-color-black-10a);
--salt-palette-alpha-active-alt: var(--salt-color-black-20a);
}

.salt-theme[data-mode="light"] {
/* added the below token, needs renaming*/
--salt-palette-alpha-weaky: var(--salt-color-black-fade-background-selection);
--salt-palette-alpha-weaker: var(--salt-color-black-fade-background-hover);
/* added alpha tokens, need renaming */
--salt-palette-alpha-hover-alt: var(--salt-color-black-fade-background-hover);
--salt-palette-alpha-active-alt: var(--salt-color-black-fade-background-selection);
}

.salt-theme[data-mode="dark"] {
/* added the below token, needs renaming*/
--salt-palette-alpha-weaky: var(--salt-color-white-fade-background-selection);
--salt-palette-alpha-weaker: var(--salt-color-white-fade-background-hover);
/* added alpha tokens, need renaming */
--salt-palette-alpha-hover-alt: var(--salt-color-black-fade-background-hover);
--salt-palette-alpha-active-alt: var(--salt-color-black-fade-background-selection);
}
.salt-theme {
/*added 2 colors to current theme, not the same opacity but same would need another 2 tokens in opacity*/
--salt-color-white-fade-background-hover: rgba(255, 255, 255, var(--salt-opacity-8));
--salt-color-white-fade-background-selection: rgba(255, 255, 255, var(--salt-opacity-15));
}
.salt-theme,
.salt-theme-next {
--salt-actionable-alpha-background-hover-alt: var(--salt-palette-alpha-hover-alt);
--salt-actionable-alpha-background-active-alt: var(--salt-palette-alpha-active-alt);
--salt-actionable-alpha-background-hover: var(--salt-palette-alpha-weaker);
--salt-actionable-alpha-background-active: var(--salt-palette-alpha-weaky);
}

/* ------------------------------- */

.saltGhostButton {
align-items: var(--saltGhostButton-alignItems, center);
appearance: none;
background: var(--saltGhostButton-background, var(--ghostButton-background));
border-color: var(--saltGhostButton-borderColor, var(--ghostButton-borderColor, transparent));
border-style: var(--saltGhostButton-borderStyle, solid);
border-width: var(--saltGhostButton-borderWidth, var(--salt-size-border, 0));
border-radius: var(--saltGhostButton-borderRadius, var(--salt-palette-corner-weak, 0));
color: var(--saltGhostButton-text-color, var(--ghostButton-text-color));
cursor: var(--saltGhostButton-cursor, pointer);
display: inline-flex;
gap: var(--salt-spacing-50);
justify-content: var(--saltGhostButton-justifyContent, center);
font-size: var(--saltGhostButton-fontSize, var(--salt-text-fontSize));
font-family: var(--saltGhostButton-fontFamily, var(--salt-text-action-fontFamily));
line-height: var(--saltGhostButton-lineHeight, var(--salt-text-lineHeight));
letter-spacing: var(--saltGhostButton-letterSpacing, var(--salt-text-action-letterSpacing));
text-transform: var(--saltGhostButton-textTransform, var(--salt-text-action-textTransform));
padding: 0 var(--saltGhostButton-padding, calc(var(--salt-spacing-100) - var(--saltGhostButton-borderWidth, var(--salt-size-border, 0))));
margin: var(--saltGhostButton-margin, 0);
height: var(--saltGhostButton-height, var(--salt-size-base));
min-width: var(--saltGhostButton-minWidth, unset);
position: relative;
text-align: var(--saltGhostButton-textAlign, var(--salt-text-action-textAlign));
text-decoration: none;
transition: none;
width: var(--saltGhostButton-width, auto);
-webkit-appearance: none;
-webkit-tap-highlight-color: transparent;
font-weight: var(--saltGhostButton-fontWeight, var(--salt-text-action-fontWeight));
}

/* Pseudo-class applied to the root element on focus */
.saltGhostButton:focus-visible {
outline-style: var(--salt-focused-outlineStyle);
outline-width: var(--salt-focused-outlineWidth);
outline-color: var(--salt-focused-outlineColor);
outline-offset: var(--salt-focused-outlineOffset);
background: var(--saltGhostButton-background-hover, var(--ghostButton-background-hover));
color: var(--saltGhostButton-text-color-hover, var(--ghostButton-text-color-hover));
}

/* Pseudo-class applied to the root element on focus when Button is active */
.saltGhostButton.saltGhostButton-active:focus-visible,
.saltGhostButton:focus-visible:active {
background: var(--saltGhostButton-background-active-hover, var(--ghostButton-background));
color: var(--saltGhostButton-text-color-active-hover, var(--ghostButton-text-color));
}

/* Pseudo-class applied to the root element on hover when Button is not active or disabled */
.saltGhostButton:hover {
background: var(--saltGhostButton-background-hover, var(--ghostButton-background-hover));
color: var(--saltGhostButton-text-color-hover, var(--ghostButton-text-color-hover));
}

/* Pseudo-class applied to the root element when Button is active and not disabled */
.saltGhostButton:active,
.saltGhostButton.saltGhostButton-active {
background: var(--saltGhostButton-background-active, var(--ghostButton-background-active));
color: var(--saltGhostButton-text-color-active, var(--ghostButton-text-color-active));
}

/* Styles applied when the button triggers a dialog or menu */
.saltGhostButton[aria-expanded="true"][aria-haspopup="menu"],
.saltGhostButton[aria-expanded="true"][aria-haspopup="dialog"] {
background: var(--saltGhostButton-background-active, var(--ghostButton-background-active));
color: var(--saltGhostButton-text-color-active, var(--ghostButton-text-color-active));
border-color: var(--saltGhostButton-borderColor-active, var(--ghostButton-borderColor-active));
}

/* Pseudo-class applied to the root element if disabled={true} */
.saltGhostButton:disabled,
.saltGhostButton-disabled,
.saltGhostButton-disabled:active,
.saltGhostButton-disabled:focus-visible,
.saltGhostButton-disabled:focus-visible:active,
.saltGhostButton-disabled:hover {
background: var(--saltGhostButton-background-disabled, var(--ghostButton-background-disabled));
color: var(--saltGhostButton-text-color-disabled, var(--ghostButton-text-color-disabled));
cursor: var(--saltGhostButton-cursor-disabled, var(--salt-actionable-cursor-disabled));
}

/* TODO: update tokens*/
.saltGhostButton {
--ghostButton-text-color: var(--salt-content-primary-foreground);
--ghostButton-text-color-hover: var(--salt-content-primary-foreground);
--ghostButton-text-color-active: var(--salt-content-primary-foreground);
--ghostButton-text-color-disabled: var(--salt-content-primary-foreground-disabled);

--ghostButton-background-active: var(--salt-actionable-alpha-background-active);
--ghostButton-background-hover: var(--salt-actionable-alpha-background-hover);
}

.saltGhostButton.saltGhostButton-solid {
--ghostButton-text-color: var(--salt-content-bold-foreground);
--ghostButton-text-color-hover: var(--salt-content-bold-foreground);
--ghostButton-text-color-active: var(--salt-content-bold-foreground);
--ghostButton-text-color-disabled: var(--salt-content-bold-foreground-disabled);

--ghostButton-background-active: var(--salt-actionable-alpha-background-active-alt);
--ghostButton-background-hover: var(--salt-actionable-alpha-background-hover-alt);
}
Loading
Loading