-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases/1.5.1 #1234
base: master
Are you sure you want to change the base?
Releases/1.5.1 #1234
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1234 +/- ##
==========================================
+ Coverage 87.16% 87.19% +0.02%
==========================================
Files 113 113
Lines 10287 10289 +2
Branches 4045 4046 +1
==========================================
+ Hits 8967 8971 +4
+ Misses 727 726 -1
+ Partials 593 592 -1 ☔ View full report in Codecov by Sentry. |
@marscher I really don't know how to proceed. I made some progress but it took many hours and it still isn't done and I have to get the release out. The issues appear mostly linked to poetry which seems to have no compatibility with earlier behaviors. The same pipeline we used last release doesn't work because they are forcing changes which break our scripts. We aren't the first to complain that they took a PEP and deciding it was mandatory for everyone to follow it. I have tried forcing the azure to publish the bad wheels so I can try to triage the source. I know the jar is in the sdist, but somehow is missing from the wheel. I will try next to merge in pelson patch to see if it addresses it. I know it may seem like a good idea to modernize, but this tool is not a replacement in that it has very limited capabilities compared to setup.py and tons of downsides. Locally forcing builds through pip is a huge drag when I want to debug windows issues mean it activity impedes progress. I have had no luck getting an arm target in azure so I am going to give up on that one. |
Sorry to hear that is is so troublesome. Since when did we use poetry to build wheels? I thought |
setuptools is missing in the windows job (stage install-test) |
also disable manylinux stages for testing
check if Python-3.13 gets downloaded
The only issue was that the test jar was not build due to setuptools missing in the job. I've added the manylinux-aarch64 image and it seems to work. |
We'll have a problem with the manylinux aarch64 job, because: ##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes. For more information, see https://go.microsoft.com/fwlink/?linkid=2077134 We probably need to split it up. |
I am not sure why we would ever run so long!? Our builds should finish in 5 of less. For for poetry isn't that the name of the pyproject.toml build system. The issues that I am tracking all matched their gitbuh issue list. Maybe I am confused between the build systems using that tool. |
Oh I see. It is total time. Well that is a problem. I guess the only choice will be to split into release1, release2, release3. We could cut down on the tests I suppose. Perhaps the gc fix will give us a speed boost on the windows system. |
Still working on a release