Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly merges dataCenterInfo.metadata. fixes #144 #145

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

danielsan
Copy link

variable metadataResult containing the default values was overwriting all the custom values provided by the user, making the custom values useless.

The issue was fixed by changing the order of the arguments passed to the merge function.

@jquatier
Copy link
Owner

@danielsan Just curious, what value were you trying to set? This seems like it would only be a problem if you were trying to override a value coming in from the AWS metadata. Usually we treat the AWS metadata as the source of truth, hence the ordering here.

@danielsan
Copy link
Author

I'm running applications inside Docker containers with the network configured as NAT, thus they get different IPs from the host, so when the AWS info comes back the IP address is not the one we need to register in Eureka

@danielsan
Copy link
Author

I'm actually using my fork as the dependency right now.

@danielsan
Copy link
Author

Is it possible to merge this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants