fix overlapping background events, fixes #2452

[chazzlabs]

This PR addresses two issues with how background events are rendered using both the overlap and no-overlap layout algorithms. I opted for the change I made due to its simplicity and the unlikelihood that it would have any adverse effects elsewhere in the calendar. It appears to me that the implementation of the no-overlap layout algorithm very deliberately returns different types for the width and xOffset style values than does the overlap algorithm; given this it seemed most reasonable to correct how those values are handled when rendering events in TimeGridEvent.

I added two stories under "Additional Examples > Layout" to demonstrate the overlap/no-overlap behavior since that seemed like the most appropriate location for them.

[cutterbl]

Thank You for contributing to Big Calendar! This is good stuff, but I do want to point out a few things I'm seeing.

Concerning the general layout of the 'no-overlap' algorithm with background events: this is 'no-overlap', as provided to standard events

While this is the new 'no-overlap' as applied to background events

There are two differences to notice here.

The first is that the background events actually do overlap, if only slightly, as opposed to the standard events, which have a small gap.

The second is the overall width of the background events. Notice that they extend all the way to the edge of the column? The 'gap' we've had is intentional, as it allows for slot selection without firing the 'onSelectEvent' (yes, background events will also fire this on click).

Really like where you're going here. Honestly, I didn't write or approve the backgroundEvents code (before I got heavily involved). Personally believe that the onSelectEvent should never fire on background events, and personally would prefer the 'no-overlap' as the only layout for background events. But that's me, and I worry that attempting to change that now might upset some existing implementations. (Maybe those changes in the 'next' version...)

[chazzlabs]

Thanks for the feedback! I'll go ahead and make the necessary updates to have backgroundEvents behave similarly to events with respect to their size and position. I agree that the other enhancements seem more appropriate for a future version given the potential breaking changes for some folks.

[chazzlabs]

I'm not sure of the rationale behind why backgroundEvents were styled differently than events with regard to layout, but my latest commit makes the layout styling consistent for both kinds of events which seems like what we wanted to achieve.

[cutterbl]

@chazzlabs Looks great. Nice work.

[github-actions]

🎉 This PR is included in version 1.10.3 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀