Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: issue 2529 #2532

Merged
merged 1 commit into from
Mar 12, 2024
Merged

fix: issue 2529 #2532

merged 1 commit into from
Mar 12, 2024

Conversation

forceddd
Copy link
Contributor

Fixed an issue where component DayColumn would always update slotMetrics after the child component had finished rendering.
This causes the subcomponent to call slotMetrics.getRange with the properties min and max as before.
Here is the issue #2529
@cutterbl
https://github.com/jquense/react-big-calendar/assets/63057542/7670001c-cd11-41df-856c-7093f52f0c4a

@forceddd
Copy link
Contributor Author

My English level is not very good. If my description of this pr confuses you, please let me know and I will be more clear.

@cutterbl cutterbl merged commit e25f187 into jquense:master Mar 12, 2024
1 check passed
Copy link

🎉 This PR is included in version 1.11.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cutterbl
Copy link
Collaborator

@forceddd We have people reporting issues (#2536) after this update. Would you be willing to take a look at the issue?

@forceddd
Copy link
Contributor Author

forceddd commented Mar 23, 2024 via email

@forceddd forceddd deleted the fix/issue-2529 branch May 8, 2024 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants