Merge pull request #121 from jr-leary7/dev

fixed randomness in knot subsampling in marge2 -- closes #120
jr-leary7 · Sep 18, 2023 · 58a8440 · 58a8440
2 parents 6664fe8 + 638918c
commit 58a8440
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/R/getFittedValues.R b/R/getFittedValues.R
@@ -106,7 +106,7 @@ getFittedValues <- function(test.dyn.res = NULL,
                            }
                            if (log1p.norm) {
                              gene_df <- dplyr::mutate(gene_df,
-                                                      expression_log1p = log1p(rna),
+                                                      rna_log1p = log1p(rna),
                                                       scLANE_pred_log1p = log1p(scLANE_pred),
                                                       scLANE_ci_ll_log1p = log1p(scLANE_ci_ll),
                                                       scLANE_ci_ul_log1p = log1p(scLANE_ci_ul))

diff --git a/R/marge2.R b/R/marge2.R
@@ -166,7 +166,7 @@ marge2 <- function(X_pred = NULL,
         X_red2 <- max_span(X_red = X, q = q)
         X_red <- intersect(X_red1, X_red2)
         if (length(X_red) > n.knot.max) {
-          set.seed(as.integer(length(X_red)))
+          set.seed(as.integer(mean(Y)))
           X_red <- sample(X_red, size = n.knot.max)
         }
       } else {