update: speaker add social site links #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tamascsaba
commented
Nov 16, 2023
•
tamascsaba
commented
- add social site links to the speaker page
tamascsaba
force-pushed
the
update-speaker-details
branch
2 times, most recently
from
2b39a42 to
da62cef
Compare
✅ Deploy Preview for jsconf-jp-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tamascsaba
force-pushed
the
update-speaker-details
branch
from
da62cef to
5fecd26
Compare
|
@tamascsaba can you please rebase? |
✅ Deploy Preview for jsconf-jp-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
tamascsaba
force-pushed
the
update-speaker-details
branch
2 times, most recently
from
0006123 to
b61acbb
Compare
martinheidegger
requested changes
Nov 16, 2023
tamascsaba
changed the title
tamascsaba
force-pushed
the
update-speaker-details
branch
2 times, most recently
from
909dd15 to
ffe4608
Compare
tamascsaba
changed the title
Mastodon is a ugly a little, but only two speakers has mastodon's link. |
martinheidegger
force-pushed
the
update-speaker-details
branch
2 times, most recently
from
6dc93cd to
eb9e4b4
Compare
martinheidegger
force-pushed
the
update-speaker-details
branch
from
6867162 to
bc6a22d
Compare
|
As mentioned in #389 (comment) I added the use of styled icons. Additionally i added the homepage link and the pronouns: 
|
martinheidegger
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.