feat: add leading dot check

jsdelivr · Mar 29, 2024 · b627162 · b627162
1 parent 964bae4
commit b627162
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/measurement/schema/utils.ts b/src/measurement/schema/utils.ts
@@ -39,7 +39,7 @@ export const joiValidateDomainForDns = () => (value: string, helpers: CustomHelp
 		return value;
 	}
 
-	if (validator.isFQDN('example' + value, options)) {
+	if (value[0] === '.' && validator.isFQDN('example' + value, options)) {
 		return value.substring(1);
 	}
 

diff --git a/test/tests/e2e/cases/dns.test.ts b/test/tests/e2e/cases/dns.test.ts
@@ -38,27 +38,35 @@ describe('dns mesurement', () => {
 		const { id } = await got.post('http://localhost:80/v1/measurements', { json: {
 			target: '.',
 			type: 'dns',
+			measurementOptions: {
+				query: {
+					type: 'ANY',
+				},
+			},
 		} }).json();
 
 		const response = await waitMesurementFinish(id);
 
 		expect(response.body.status).to.equal('finished');
 		expect(response.body.results[0].result.status).to.equal('finished');
-		expect(response.body.results[0].result.hops.length).to.be.above(0);
 		expect(response).to.matchApiSchema();
 	});
 
 	it('should finish successfully in case of tld target', async () => {
 		const { id } = await got.post('http://localhost:80/v1/measurements', { json: {
 			target: '.com',
 			type: 'dns',
+			measurementOptions: {
+				query: {
+					type: 'ANY',
+				},
+			},
 		} }).json();
 
 		const response = await waitMesurementFinish(id);
 
 		expect(response.body.status).to.equal('finished');
 		expect(response.body.results[0].result.status).to.equal('finished');
-		expect(response.body.results[0].result.hops.length).to.be.above(0);
 		expect(response).to.matchApiSchema();
 	});
 });