Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: /limits endpoint #543

Merged
merged 21 commits into from
Sep 22, 2024
Merged

feat: /limits endpoint #543

merged 21 commits into from
Sep 22, 2024

Conversation

alexey-yarmosh
Copy link
Member

Fixes #328
Fixes #536

MartinKolarik
MartinKolarik approved these changes Sep 22, 2024
View reviewed changes
Copy link
Member

@MartinKolarik MartinKolarik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realized the consumed field doesn't actually make sense here because, in the headers, its meaning is related to the request (the number of rate limit points consumed by the request). Total consumed points can be calculated easily so I removed it.

@MartinKolarik MartinKolarik merged commit f55cf19 into master Sep 22, 2024
5 checks passed
@MartinKolarik MartinKolarik deleted the limits-endpoint branch September 22, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinKolarik MartinKolarik MartinKolarik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check random e2e failures Limits endpoint
2 participants
@alexey-yarmosh @MartinKolarik