feat: rate limits for GET #549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-yarmosh
force-pushed
the
get-rate-limiter
branch
from
8dbc87a
to
0f3db42
Compare
alexey-yarmosh
force-pushed
the
get-rate-limiter
branch
from
0f3db42
to
2b1dfc9
Compare
There was a problem hiding this comment.
After some more thought, I think this limit should always be applied per IP address. The effect will be more or less the same, but there is a good reason we had CORS configured to disallow sending the tokens on GET. Doing so triggers additional preflight requests, which add extra load, and also makes it much harder to add a CDN caching for finished measurements in the future.
alexey-yarmosh
force-pushed
the
get-rate-limiter
branch
from
c5709a8
to
6e34c3b
Compare
MartinKolarik
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #526