Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apache_rocketmq_update_config.rb #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsherwood0
Copy link
Owner

Add a timeout to eliminate the hang in the check method

This fix is to ensure that if all else fails, the check will timeout and allow progress to continue instead of hanging on a host that does not reply as expected. This addresses Issue rapid7#19035.

Verification

List the steps needed to make sure this thing works

  • Start msfconsole
  • use exploit/multi/http/apache_rocketmq_update_config
  • Set RHOSTS and RPORT to host/port that is not responding as RocketMQ should (e.g., it's down or its not RocketMQ)
  • check
  • Verify that the check will eventually time out even if it does not receive an expected RocketMQ response.
  • Verify that the check does not hang on servers that fail to respond as expected.

Add a timeout to eliminate the hang in the check method
Eliminate rescue with no specific exception types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant