Add jpe,jif,jfif as image/jpeg mime type #291
Conversation
jfif is the only one that I have actual files for, but for completeness based on https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types#jpeg_joint_photographic_experts_group_image I included jpe and jif.
| "compressible": false, | ||
| "extensions": ["jpe", "jif", "jfif"], | ||
| "sources": [ | ||
| "https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types#jpeg_joint_photographic_experts_group_image" |
There was a problem hiding this comment.
We need the primary source to be linked fom where these are defined. The MDN site is a secondary source.
There was a problem hiding this comment.
Its frustrating because it's not mentioned on the IANA site, but it is an ISO standard.
This is from the official JPEG site https://jpeg.org/jpeg/workplan.html:
ITU-T T.871 (2011) — ISO/IEC 10918-5:2013:
JPEG File Interchange Format (JFIF)
(ITU page, ITU edition 1, ISO page, ISO edition 1, in stage 90.93)
Is the ISO page good enough?
There's also this via the JFIF Wikipedia page: https://www.w3.org/Graphics/JPEG/jfif3.pdf
There was a problem hiding this comment.
Gotcha. I wonder where did the MDN page get it then? Maybe I am confused, but your quotes does not say that JFIF is a file extension, just the abbreviation of JPEG File Interchange Format.
There was a problem hiding this comment.
Maybe we can contact one of these standards bodies for clarification.
There was a problem hiding this comment.
It clearly is a file extension for jpeg files same as this Adobe page talks about it https://www.adobe.com/creativecloud/file-types/image/raster/jpeg-file.html - but it doesn't seem like it was standardised anywhere.
There was a problem hiding this comment.
Gotcha. Unfortunately this just isn't the purpose of this module, to be a registry -- it is built to be a JSON version of the three sources listed at the top of the module's README. We can accept other ones that are not in there, but it needs to be very clear standard or like something is broken with our scraping of those three sources. I suggest the best way forward without some kind of confirmation from JPEG itself that someone get it registered in IANA. This module is slowing eliminating all entries not included in those three sources, and this seems contrary to the module's direction.
There was a problem hiding this comment.
Ideally for file extensions, we are looking for a first-party source which clearly states that "file extension X represents mime type Y"
There was a problem hiding this comment.
Overall, I would like to ideally see if we can get these added to one of our upstream sources or fine some page to link to. I actually emailed JPEG to ask them, since it wasn't clear if you did that or not already. I'll see what they say.
There was a problem hiding this comment.
As I see it there is no primary source for even 'jpg' being an official extension. IANA doesn't include it. You include it because Apache does and they also include 'jpe' - but with no reason given.
image/jpeg jpeg jpg jpe
JPEG don't specify any file extensions, Windows just decided to use jpg to keep it short and everyone else jpeg.
So you don't think you can find a primary source for 'jpg'.
So I doubt we'll get much out of JPEG - I don't think they care about the extension.
There was a problem hiding this comment.
Actually now that I've seen that jpe is included in the Apache list I can remove it from this PR.
I'm happy if you want to close this - it makes sense to have a clear definition for what is or isn't included here.
|
Sorry, did not mean to close the PR. |
|
please tell me what is the status of the task? |
|
So, what do we need to do to add JFIF as an acceptable extension for image/jpeg? |
Something from IANA, Apache or NGINX that specifies JFIF as a mimetype. It seems that nothing from either JPEG group themselves or IANA specify it. If you need to have jfif specified as a mimetype you will have to look for other libraries that do things like sniffing the binary contents of the files. |
|
... or request a new mime type: https://www.iana.org/form/media-types - I don't know the answers to all their questions. |
Oh! But JFIF is not a mime type. Is an extension for |
jfif is the only one that I have actual files for, but for completeness based on https://developer.mozilla.org/en-US/docs/Web/Media/Formats/Image_types#jpeg_joint_photographic_experts_group_image I included jpe and jif.
Fix for #283