Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Update audio/webm extension #323

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xNevrroXx
Copy link

The audio/webm mime type extension was incorrect.

The audio/webm mime type extension was incorrect.
@UlisesGascon
Copy link
Member

Hi @xNevrroXx! Thanks for proposing this change! 👍

I was checking some online resources and seems like .weba is only audio (audio/webm) while .webm is video (video/webm).

Can you provide additional context for this change? :)

@xNevrroXx
Copy link
Author

Hi, @UlisesGascon
Maybe you are right. Some sites indicate that .weba is an extension of the audio/webm mime type. But others indicate both audio/webm and video/webm also have the extension .webm.
But, I checked out the ability of browsers to play audio-name.weba files - they can play them exactly the same as audio-name.webm. But if we will talk about Windows OS 11 (imagine that we are trying to download some files to the client side) - this one cannot play audio-name.weba, but can play audio-name.webm files with native music player.

So, it's the hard question)
Thanks for your attention

@dougwilson
Copy link
Contributor

Unless upsteam Apache actually changed the mapping, your change will be overwritten because you changed a generated file. You should contact Apache project for changes to Apache mappings.

@xNevrroXx
Copy link
Author

@UlisesGascon
It seems that Wikipedia doesn't know about .weba audio extension either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants