-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2D slam Cartographer for turtlebot navigation #236
base: master
Are you sure you want to change the base?
Conversation
1. add cartographer_ros as default run_depned 2. add repository cartographer_turtlebot in .rosinstall 3. modify the README.md for 2
README.md
Outdated
$ wstool set robot-programming https://github.com/jsk-enshu/robot-programming --git -t src | ||
$ wstool set dynamixel_urdf https://github.com/jsk-enshu/dynamixel_urdf --git -t src | ||
$ wstool set robot-programming https://github.com/jsk-enshu/robot-programming --git -u -t src | ||
$ wstool merge -t src src/robot-programming/enshu.rosinstall |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you use .rosinstall file, you will not need 'set robot-programming'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for review. Modification: ee7f13e
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
forget to add launch file using cartographer?
when you add launch file, please try to add roslaunch-check
, understanding test mechanism will be a part of NEDO project
https://github.com/jsk-enshu/robot-programming/blob/master/dxl_armed_turtlebot/CMakeLists.txt#L9-L14
I thought to use the original launch file in Should I create the similar launch file under this repository? |
I'm expected to update https://github.com/jsk-enshu/robot-programming/blob/master/dxl_armed_turtlebot/launch/dxl_armed_turtlebot_navigation.launch to add 'arg' to switch localization/mapping method. |
…tlebot_navigation.launch. - intorduce arg 'do_slam' to switch between slam and acml (only localization), along with arg 'slam_mode' to choice between karto_slam and cartographer. - modified the configuration for cartographer, based on the 0.2.0 version.
Modified dxl_armed_turtlebot_navigation.launch with following points.
|
https://github.com/tork-a/roomblock/tree/master/roomblock_mapping/config or @7675t might help you. |
@tongtybj But it may be possible ver.0.2 is worse than 0.3. I haven't compared those intently. |
@7675t Than you for your advice, tajima san! I tried with But, what makes me confused is this flag is set to The possible reason is that the latest cartographer might omit the horizontal angular velocity if Then I tried to set the horizontal angular velocity to zero since I think the yaw velocity from imu should not be omitted, and get same good result as shown in the following GIF. The send RP about this commit: https://github.com/googlecartographer/cartographer_turtlebot/pull/94/files. Hope they can merge this PR. |
Yes, difference between 0.2 and the latest is annoying, not back-compatible. In kinetic we cant release the latest, but can use it by building by ourselves. We may be safe to supply both version config files for a while, like turtlebot_v020.lua or something,expecting eventually migrated to newer release. |
Better 2D slam than gmapping or karto_slam: