Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dialogflow_task_executive] Fix bugs when subscribing /text (std_msgs/String) topic #328

Merged
merged 1 commit into from
Jan 31, 2022
Merged

[dialogflow_task_executive] Fix bugs when subscribing /text (std_msgs/String) topic #328

merged 1 commit into from
Jan 31, 2022

Conversation

mqcmd196
Copy link
Member

@mqcmd196 mqcmd196 commented Jan 27, 2022 •
edited
Loading

Original code raises the error because

jsk_3rdparty/dialogflow_task_executive/node_scripts/dialogflow_client.py

Line 165 in 712cf10

self.hotword_cb(data)
. data is not defined.

@mqcmd196 mqcmd196 requested a review from iory January 27, 2022 11:39
@k-okada
Copy link
Member

k-okada commented Jan 31, 2022

Sorry this is my fault at #317

@k-okada k-okada merged commit 4a37c34 into jsk-ros-pkg:master Jan 31, 2022
@mqcmd196 mqcmd196 deleted the PR/fix_dialogflow_text_sub branch February 1, 2022 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iory iory iory approved these changes

Assignees
No one assigned
Labels
dialogflow_task_executive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mqcmd196 @k-okada @iory