Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix startup crash #309

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

fix startup crash #309

wants to merge 3 commits into from

Conversation

m-i-k-e-e
Copy link
Contributor

assuming int as boolean was not working

@francisdb
Copy link
Contributor

@jsm174
Copy link
Owner

jsm174 commented Jun 11, 2024

@francisdb - have we seen this issue before? I thought people do checks like this all the time.

@m-i-k-e-e - This looks wrong, no space between the 0 and Then

Screenshot 2024-06-11 at 7 37 17 AM

@francisdb
Copy link
Contributor

vpmColourised is actually "" and vbscript does not support If "" Then. Values like "0" or "true" work

Controller.Games(cGameName).Settings.Value("dmd_colorize") on windows returns 0 because vpinmame comes with some default settings

Not sure I picked the correct locations but pretty sure these are set up by default

https://github.com/vpinball/pinmame/blob/7bb409ec08cf9e4221a1463f58defcfb4e558437/src/win32com/VPinMAMEConfig.cpp#L81-L91

https://github.com/vpinball/pinmame/blob/7bb409ec08cf9e4221a1463f58defcfb4e558437/src/unix/config.c#L78-L87

@jsm174 is this something you would want to add to standalone?

@francisdb
Copy link
Contributor

francisdb commented Jun 11, 2024

@m-i-k-e-e a rebase should fix the build checks, but not a big deal as this was a known issue

@francisdb
Copy link
Contributor

I wonder if all the other recent bigus tables have this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants