-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a preliminary IANA section with placeholders. #27
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preliminary review
spec/index.html
Outdated
<!--p>Other specifications MAY create further structured subtypes | ||
by using `+ld+json` as a suffix for a new base subtype, as in | ||
`application/example+ld+json`. | ||
Unless defined otherwise, such subtypes use the same | ||
fragment identifier behavior as `application/ld+json`.</p--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we think this is the case, we need to file an issue and remove the commented text from the spec.
Otherwise, remove.
<!--p>Other specifications MAY create further structured subtypes | |
by using `+ld+json` as a suffix for a new base subtype, as in | |
`application/example+ld+json`. | |
Unless defined otherwise, such subtypes use the same | |
fragment identifier behavior as `application/ld+json`.</p--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply removed the section for now.
spec/index.html
Outdated
This includes the ability to associate a file extension with a `profile` parameter.</p> | ||
<p> | ||
When used as a <a data-cite="RFC4288#section-4.3">media type parameter</a> [[RFC4288]] | ||
in an <a data-cite="rfc7231#rfc.section.5.3.2">HTTP Accept header</a> [[RFC7231]], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in an <a data-cite="rfc7231#rfc.section.5.3.2">HTTP Accept header</a> [[RFC7231]], | |
in an <a data-cite="rfc9110#rfc.section.12.5.1">HTTP Accept header field</a> [[RFC9110]], |
Probably, we could simplify this section, eg.
When using this parameter in content negotiation (see Section 12.5 of RFC9110), its value MUST be
enclosed in double quotes...
Q: is the procedure above specific to the profile parameter or it is generally valid for all media type parameters? In case, I can double check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it's generally true about parameter values.
<dt>Optional parameters:</dt> | ||
<dd> | ||
<dl> | ||
<dt><code>profile</code></dt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: this section is very long. To ensure it is aligned between yaml+ld and json+ld we could probably just reference
the parameter from either the ld+json registration or the json-ld specification document which was used for the registration of ld+json. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shortened, now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
<a data-cite="JSON-LD11##iana-considerations"> and additionally defines the following:</a> | ||
</p> | ||
<dl> | ||
<dt><code>http://www.w3.org/ns/json-ld#extended</code></dt> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be http://www.w3.org/ns/yaml-ld#extended
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That wasn’t an accident, as this spec is under the json-led umbrella, but it is worth considering.
Fixes #14.
Fixes #25.
cc/ @anatoly-scherbakov @juusoautiosalo
Preview | Diff