Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SecretProviderClass typo #338

Merged
merged 1 commit into from
Aug 6, 2023

Conversation

mriedmann
Copy link
Contributor

There is a tiny typo in the SecretProviderClass custom function "withClientId". The azure operator is specifically asking for clientID rather than clientId.

Adding the wrong casing results in the following error:

secrets-store E0804 16:23:24.908716       1 reconciler.go:223] "failed to reconcile spc for pod" err="failed to rotate objects for pod ***, err: rpc error: code = Unknown desc = failed to mount objects, error: failed to create auth config, error: could not find clientid in secrets(map[])" spc="***" pod="***" controller="rotation"

The parameters are not defined in the CRD and therefore vulnerable to typos.

@mriedmann mriedmann force-pushed the fix-secretProviderClass-typo branch from a036d33 to 2586082 Compare August 4, 2023 16:35
@xvzf xvzf merged commit fc79074 into jsonnet-libs:master Aug 6, 2023
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants