Skip to content
This repository has been archived by the owner on Nov 22, 2017. It is now read-only.

Fixed two bugs that were wrecking my collectd servers, notes included in each commit. #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dnf
Copy link

@dnf dnf commented Mar 9, 2012

No description provided.

dnf added 2 commits March 8, 2012 17:27
…L, which this function receives from several plugins: df, uptime, memory
@octo
Copy link
Contributor

octo commented Mar 9, 2012

FYI, the first issue is also fixed by collectd/collectd@acd2fa4.

The second issue is avoided in the upstream sources by allowing the user to specify whether to always add the data source name or do this only when the data set has multiple data sources. This was changed in a couple of commits, the most relevant one is collectd/collectd@184f1db.

I'd fix the second issue by not passing NULL in https://github.com/jssjr/collectd-write_graphite/blob/master/src/write_graphite.c#L563 but rather ds->ds[0].name.

Best regards,
—octo

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants