Recommend a channel with a URL parameter #8
Conversation
src/index.html
Outdated
| return(false); | ||
| } | ||
|
|
||
| var containerElem = document.getElementById("recommend-channel-container"); |
There was a problem hiding this comment.
at a glance, I'm not sure what containerElem is - sounds like it might be for the whole page?
maybe it could be called channelContainerElem
src/index.html
Outdated
|
|
||
| var containerElem = document.getElementById("recommend-channel-container"); | ||
| var channelElem = document.getElementById("recommend-channel"); | ||
| var channel = getQueryVariable("recommendChannel"); |
There was a problem hiding this comment.
let's call it recommendedChannel instead of recommendChannel?
I think that'll make more sense from the referrer's side (like from dccodecoffee.com)
|
awesome! I have two more ideas for this. 1: We could make this tile link to the channel via 2: Text change suggestion: |
|
one more: 3: maybe we want to show the card saying "join channels" even if we don't recommend one? It wouldn't list a recommended channel or link to a specific channel (it could link to dctech.slack.com). (I'm only 50% on wanting this) |
|
once this is in we can replace two buttons with just one on so many sites 🎉 can become one button that says: |
|
We discussed IRL:
|
|
@caseywatts Ready for another look |
|
Code looks good! Let's test these cases before merging:
|
Resolves #7 - Trying out @caseywatts's idea of conditionally showing a 4th step to point invitees to a specific channel. Add
?recommendChannel=hito the url. Is this what you had in mind @caseywatts?There are probably some edge cases to consider. For example this doesn't scrub the query param, although
?recommendChannel=<script>alert()</script>properly escapes 😅.