Merge pull request jupyter-widgets#3171 from joseph2rs/widget_image_f…

…ix_revoke_object_url fix: [Widget Image] Remove oldurl string check since it's always a string and prevent the ObjectURL cleaning resulting in a memory leak.
jtpio · Mar 25, 2021 · 24628f0 · 24628f0
2 parents 8cf38cf + 1ca079e
commit 24628f0
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 3 deletions.
diff --git a/packages/controls/src/widget_audio.ts b/packages/controls/src/widget_audio.ts
@@ -62,7 +62,7 @@ export class AudioView extends DOMWidgetView {
     // Clean up the old objectURL
     const oldurl = this.el.src;
     this.el.src = url;
-    if (oldurl && typeof oldurl !== 'string') {
+    if (oldurl) {
       URL.revokeObjectURL(oldurl);
     }
 

diff --git a/packages/controls/src/widget_image.ts b/packages/controls/src/widget_image.ts
@@ -62,9 +62,10 @@ export class ImageView extends DOMWidgetView {
     // Clean up the old objectURL
     const oldurl = this.el.src;
     this.el.src = url;
-    if (oldurl && typeof oldurl !== 'string') {
+    if (oldurl) {
       URL.revokeObjectURL(oldurl);
     }
+
     const width = this.model.get('width');
     if (width !== undefined && width.length > 0) {
       this.el.setAttribute('width', width);

diff --git a/packages/controls/src/widget_video.ts b/packages/controls/src/widget_video.ts
@@ -65,7 +65,7 @@ export class VideoView extends DOMWidgetView {
     // Clean up the old objectURL
     const oldurl = this.el.src;
     this.el.src = url;
-    if (oldurl && typeof oldurl !== 'string') {
+    if (oldurl) {
       URL.revokeObjectURL(oldurl);
     }