Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added logging of rules to the rack.errors or rack.logger #15

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added logging of rules to the rack.errors or rack.logger #15

wants to merge 3 commits into from

Conversation

scottdavis
Copy link

example output: https://gist.github.com/1163844

Rails does not support env['rack.logger'] in order to get the log messages to show up in rails you need to send messages to env['rack.errors'] which is kind of hacky but i blame this on rails for not following the rack specs recomenations. It will fall back to 'rack.logger' if it exists

@tilsammans
Copy link
Contributor

This is a great feature, since I'm a little worried other developers working on the app will not be able to discover that rack-rewrite is active and doing its magic.

They will just see the URL redirects happening without anything in routes.rb and get confused :-)

@scottdavis
Copy link
Author

any word on this? are you still actively maintaining this john?

@scottdavis
Copy link
Author

Im pretty sure he is no longer maintaining this I've tried reaching out to him via twitter with no response

@tilsammans
Copy link
Contributor

I would be fine in forking and maintaining this. What do you think?

@travisjeffery
Copy link
Collaborator

@scottdavis Hey I'm the new maintainer, would you mind rebasing your changes so everything's up to date?

@scottdavis
Copy link
Author

No time ATM working on a rather large release of compass

Sent from my iPhone

On Oct 16, 2012, at 5:00 PM, Travis Jeffery [email protected] wrote:

@scottdavis Hey I'm the new maintainer, would you mind rebasing your changes so everything's up to date?


Reply to this email directly or view it on GitHub.

@travisjeffery travisjeffery mentioned this pull request Jan 9, 2014
@paulhenrich
Copy link

I'm taking a stab at this in a branch on my fork. Going to try to maintain commit attribution, but I may have to do some manual work on the merge commit, and I will probably bump the dates on the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants