Pattern matching fix #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have discovered that in some odd cases the rewrite will fail to occur despite the fact that it matched the pattern. I then discovered that sometimes
Rule#string_matches?returns an Fixnum. This works just fine if the integer is not zero. If the integer is zero it causes Rule#matches to fail and the rewrite will not occur.I wondered how this was missed in the test suite, and I further discovered that
assert(0)comes back as true. I can think of no case whereassert(0)succeeding would be a good idea. So I overrided assert in test_helper to haveassert(0)fail. This revealed 14 failures which I then fixed. The only thing that might still need changing is the name of the class that inherits from Test::Unit::TestCase.