Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property to Pokemon model containing its past types #22

Merged
merged 5 commits into from
Jul 17, 2021

Conversation

phrasmotica
Copy link
Contributor

This PR adds a property to the Pokemon model containing its past types.

The data was added to PokeAPI in this PR: PokeAPI/pokeapi#457

This should NOT be merged until the data is available in the production deployment of PokeAPI; it is currently only available in the staging deployment, e.g. https://staging.pokeapi.co/api/v2/pokemon/35/.

@jtwotimes
Copy link
Owner

Any idea of when/a schedule for production PokeAPI to be updated to include changes from staging?

Additionally, I'm open to including some option to allow for PokeApiClient to connect to the staging instance, but I don't want to have to maintain feature parity if staging is frequently updated with experimental-like features that are seldom used...

@phrasmotica
Copy link
Contributor Author

@mtrdp642 sorry for the delayed response! I can confirm that the past type data is in the production PokeAPI now, you can see them by querying pokemon/clefairy on the PokeAPI home page. Hopefully this means these changes can be merged in once you're happy with them?

Copy link
Owner

@jtwotimes jtwotimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtwotimes jtwotimes merged commit 1050c35 into jtwotimes:master Jul 17, 2021
@jtwotimes jtwotimes changed the title [DO NOT MERGE] Add property to Pokemon model containing its past types Add property to Pokemon model containing its past types Jul 17, 2021
@phrasmotica phrasmotica deleted the feature/past-pokemon-types branch August 24, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants