Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Bayes optimization for hyperparameters #260

Merged
merged 32 commits into from
Apr 29, 2024
Merged

Conversation

fraimondo
Copy link
Contributor

Add BayesSearchCV from scikit-optimize: https://scikit-optimize.github.io/stable/

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

Attention: Patch coverage is 80.83333% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 90.45%. Comparing base (08dde70) to head (6302b4c).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #260      +/-   ##
==========================================
- Coverage   92.47%   90.45%   -2.02%     
==========================================
  Files          56       53       -3     
  Lines        2685     2327     -358     
  Branches      482      470      -12     
==========================================
- Hits         2483     2105     -378     
- Misses        130      145      +15     
- Partials       72       77       +5     
Flag Coverage Δ
docs 100.00% <ø> (ø)
julearn 90.45% <80.83%> (-2.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
docs/conf.py 100.00% <ø> (ø)
julearn/api.py 96.40% <100.00%> (+0.02%) ⬆️
julearn/inspect/inspector.py 100.00% <100.00%> (ø)
julearn/model_selection/__init__.py 100.00% <100.00%> (ø)
julearn/model_selection/available_searchers.py 94.28% <87.50%> (-5.72%) ⬇️
julearn/pipeline/merger.py 90.74% <84.00%> (-3.71%) ⬇️
julearn/model_selection/_skopt_searcher.py 54.54% <54.54%> (ø)
julearn/conftest.py 92.85% <80.00%> (-7.15%) ⬇️
julearn/pipeline/pipeline_creator.py 87.96% <71.42%> (-0.89%) ⬇️

... and 4 files with indirect coverage changes

@fraimondo fraimondo linked an issue Apr 24, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Apr 24, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-04-29 10:57 UTC

@fraimondo fraimondo requested a review from synchon April 24, 2024 16:44
examples/99_docs/run_hyperparameters_docs.py Outdated Show resolved Hide resolved
examples/99_docs/run_hyperparameters_docs.py Outdated Show resolved Hide resolved
examples/99_docs/run_hyperparameters_docs.py Outdated Show resolved Hide resolved
examples/99_docs/run_hyperparameters_docs.py Outdated Show resolved Hide resolved
julearn/pipeline/merger.py Outdated Show resolved Hide resolved
julearn/pipeline/tests/test_pipeline_creator.py Outdated Show resolved Hide resolved
julearn/pipeline/tests/test_pipeline_creator.py Outdated Show resolved Hide resolved
pyproject.toml Show resolved Hide resolved
@fraimondo fraimondo requested a review from synchon April 29, 2024 08:07
docs/changes/newsfragments/260.misc Outdated Show resolved Hide resolved
docs/getting_started.rst Outdated Show resolved Hide resolved
examples/99_docs/run_hyperparameters_docs.py Outdated Show resolved Hide resolved
examples/99_docs/run_hyperparameters_docs.py Outdated Show resolved Hide resolved
examples/99_docs/run_hyperparameters_docs.py Outdated Show resolved Hide resolved
julearn/pipeline/tests/test_pipeline_creator.py Outdated Show resolved Hide resolved
julearn/pipeline/tests/test_pipeline_creator.py Outdated Show resolved Hide resolved
julearn/pipeline/tests/test_pipeline_creator.py Outdated Show resolved Hide resolved
julearn/pipeline/tests/test_pipeline_creator.py Outdated Show resolved Hide resolved
Copy link
Member

@synchon synchon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs linting, else if CI passes, LGTM!

@fraimondo fraimondo merged commit 239c2c4 into main Apr 29, 2024
19 of 20 checks passed
@fraimondo fraimondo deleted the fraimondo/issue80 branch April 29, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH] Bayes optimization for hyperparameters
2 participants