This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Fix list-objects returning nothing after restarting #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jubos
suggested changes
Oct 18, 2017
lib/fakes3/file_store.rb
Outdated
| @@ -278,5 +278,11 @@ def create_metadata(content,request) | |||
| end | |||
| return metadata | |||
| end | |||
| private | |||
There was a problem hiding this comment.
Style nit: Indentation looks off here.
lib/fakes3/file_store.rb
Outdated
| @@ -21,7 +21,8 @@ def initialize(root) | |||
| @bucket_hash = {} | |||
| Dir[File.join(root,"*")].each do |bucket| | |||
| bucket_name = File.basename(bucket) | |||
| bucket_obj = Bucket.new(bucket_name,Time.now,get_objects(bucket_name, bucket)) | |||
| puts "root bucket: #{bucket_name}" | |||
There was a problem hiding this comment.
Leave the puts out to avoid console spew.
lib/fakes3/file_store.rb
Outdated
| get_object(bucket_name, File.basename(filepath), nil) | ||
| end | ||
| end | ||
| private |
lib/fakes3/file_store.rb
Outdated
| end | ||
| end | ||
| private | ||
| def get_objects bucket_name, path, root_path=nil |
There was a problem hiding this comment.
Use 2 spaces for indentation and () in the method declaration like the other methods in the class.
|
Thanks for your feedback @jubos! I actually made this PR from @saltzmanjoelh's fork (I didn't even know you could do a PR from a repo you don't own), which means I'm not able to push more code in order to amend this commit. Instead I've opened a new PR, #221, which hopefully addresses your comments, and I'll close this one. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if fake-s3 is restarted, it always returns an empty response for the
list-objectsaction. However, the objects are still there and can be fetched withget-objectif you already know the key.This PR is similar to this one, but including the extra fixes in comments from @Allactaga and @mark2997.