Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SAM2 model and post-processing #19

Merged
merged 9 commits into from
Nov 9, 2024
Merged

Added SAM2 model and post-processing #19

merged 9 commits into from
Nov 9, 2024

Conversation

mese79
Copy link
Collaborator

@mese79 mese79 commented Nov 7, 2024

  • Added SAM2 large and base_plus modes
  • Updated post-processing using SAM2 base_plus instead of light_hq_sam
  • Updates setup toml and provided envs

The setup process might be still problematic, and it needs more testing.
SAM2 can be installed easily using conda, but for pip, it will be installed from the git repo. I need to find a way to publish it to pypi since it doesn't support github link dependency.

@jdeschamps
Copy link
Member

jdeschamps commented Nov 7, 2024

Two ways forward:

  1. We could make it a dependency without Github and then write instructions in the README to install SAM2 via conda. Would that be PyPi compatible?

  2. Make SAM2 an optional dependency, detect it at run time and guard against it not being present.

What do you think?

Can you edit the README?

@mese79
Copy link
Collaborator Author

mese79 commented Nov 7, 2024

Both solutions seem good! Also, another way is to make a SAM2 pypi package just for our installation purpose.
There is one on pypi, but it seems it's not up to date and the maintainer is unknown.
First I need to check why tests won't pass anymore! :(

@jdeschamps
Copy link
Member

Both solutions seem good! Also, another way is to make a SAM2 pypi package just for our installation purpose. There is one on pypi, but it seems it's not up to date and the maintainer is unknown. First I need to check why tests won't pass anymore! :(

I would not commit to maintain a PyPi SAM 2 package! Things change too fast.

@mese79
Copy link
Collaborator Author

mese79 commented Nov 8, 2024

I commented out the sam-2 dependency from pyproject.toml since the installation of sam-2 via pip would turn into a mess easily!
So, I guess I need to update the README to emphasize the installation process using conda and the provided yaml files.

@mese79 mese79 merged commit a8707a3 into main Nov 9, 2024
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants