fix TLS crash by removing obsolete twitter-stream patch #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This patch works for me after applying it. |
|
Rebased on latest master (d5fef09, 5 Nov 2013). |
earthquake is working around an issue in old releases of twitter-stream where reconnections were not honouring @options[:ssl]. This issue was fixed in twitter-stream-0.1.15, and the now unnecessary monkey-patch crashes the program upon reconnect. Require twitter-stream ~> 0.1.15 and remove the monkey-patch to make the crashes go away.
twitter-stream ~> 0.1.16 takes care of reconnecting when no data has been received for a while. With earthquake also doing this, strange behaviour occurs when twitter-stream 0.1.16 is used. Update the dependency to twitter-stream ~> 0.1.16 and remove the reconnect-on-timeout code from Earthquake::Core to restore normal behaviour.
frasertweedale
force-pushed
the
fix-start-tls
branch
from
e2976fd
to
3ec8534
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
earthquake is working around an issue in old releases of
twitter-stream where reconnections were not honouring
@options[:ssl].
This issue was fixed in twitter-stream-0.1.15, and the now
unnecessary monkey-patch crashes the program upon reconnect.
Require twitter-stream ~> 0.1.15 and remove the monkey-patch
to make the crashes go away.