Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[utoipa-gen] request_body: Simplify ToTokensDiagnostics #1235

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

jsoo1
Copy link
Contributor

@jsoo1 jsoo1 commented Dec 13, 2024

I noticed the tokens were traversed multiple times in confusing ways, and thought it could use a touch up.

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could use a CHANGELOG.md entry under Unreleased title and Changed subtitle. Newest on top order.

Great, thanks for patch. 👍

@jsoo1 jsoo1 force-pushed the encoding/simplify-req-body-to-tokens branch from dfea7ee to 88e86e9 Compare December 17, 2024 02:57
@jsoo1 jsoo1 requested a review from juhaku December 17, 2024 02:57
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great 👍

@juhaku juhaku merged commit fa227d7 into juhaku:master Dec 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants