Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

utoipa-gen: Replace assert-json-diff with snapshot testing via insta #1253

Merged
merged 16 commits into from
Dec 21, 2024
Merged

utoipa-gen: Replace assert-json-diff with snapshot testing via insta #1253

merged 16 commits into from
Dec 21, 2024

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Dec 20, 2024 •
edited
Loading

This PR continues what #1247 has started by migrating all tests in utoipa-gen that use assert-json-diff to use insta::assert_json_snapshot!() instead.

Note that this PR currently includes #1252 to avoid conflicts from the path_derive_auto_into_responses_actix test suite.

juhaku
juhaku requested changes Dec 21, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks for putting the effort for migrating the tests 🥳

Just missing the entry or CHANGELO.md under Unreleased title and Changed subtitle at the top of the file.

@Turbo87
Copy link
Contributor Author

Turbo87 commented Dec 21, 2024

Just missing the entry or CHANGELO.md under Unreleased title and Changed subtitle at the top of the file.

done :)

Turbo87 added 16 commits December 21, 2024 21:43
@Turbo87
utoipa-gen/tests/response_derive_test: Migrate to snapshot testing
4036f0a
@Turbo87
utoipa-gen/tests/schema_derive_test: Migrate to snapshot testing
39fd5c7
@Turbo87
utoipa-gen/tests/request_body_derive_test: Migrate to snapshot testing
32ea28e
@Turbo87
utoipa-gen/tests/path_response_derive_test: Migrate to snapshot testing
7883e29
@Turbo87
utoipa-gen/tests/path_parameter_derive_test: Migrate to snapshot testing
70d509c
@Turbo87
utoipa-gen/tests/path_derive_rocket: Migrate to snapshot testing
c151b8a
@Turbo87
utoipa-gen/tests/path_derive_axum_test: Migrate to snapshot testing
53b0c29
@Turbo87
utoipa-gen/tests/path_derive_auto_into_responses_axum: Migrate to sna…
fcd7b48 
…pshot testing
@Turbo87
utoipa-gen/tests/path_derive_auto_into_responses_actix: Migrate to sn…
30f0ce1 
…apshot testing
@Turbo87
utoipa-gen/tests/path_derive_auto_into_responses: Migrate to snapshot…
acb3cad 
… testing
@Turbo87
utoipa-gen/tests/path_derive_actix: Migrate to snapshot testing
a52f875
@Turbo87
utoipa-gen/tests/path_derive: Migrate to snapshot testing
cbff9b7
@Turbo87
utoipa-gen/tests/openapi_derive: Migrate to snapshot testing
1d1f8df
@Turbo87
utoipa-gen: Migrate to snapshot testing
c25625e
@Turbo87
utoipa-gen: Remove obsolete assert-json-diff dev dependency
8837dae
@Turbo87
Add changelog entry
64643e7
@Turbo87
Copy link
Contributor Author

Turbo87 commented Dec 21, 2024

rebased on top of master now

juhaku
juhaku approved these changes Dec 21, 2024
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, let's get this show on the road. 🚀

@juhaku juhaku merged commit 2782358 into juhaku:master Dec 21, 2024
12 checks passed
@Turbo87 Turbo87 deleted the insta branch December 22, 2024 11:11
@Turbo87 Turbo87 mentioned this pull request Dec 23, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhaku juhaku juhaku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @juhaku