This repository has been archived by the owner on Mar 4, 2024. It is now read-only.
Remove the need for the requests library entirely #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addyess
force-pushed
the
akd/remove-requests-lib
branch
from
9539ffd
to
2f741b0
Compare
addyess
commented
Oct 30, 2023
reactive/docker.py
Outdated
Comment on lines
456
to
431
| r = requests.get(repository_url) | ||
| r.raise_for_status() | ||
| with open(cuda_repository_package, 'wb') as f: | ||
| for chunk in r.iter_content(chunk_size=1024): | ||
| f.write(chunk) | ||
| r.close() | ||
| with contextlib.closing(urlopen(repository_url)) as r: | ||
| with open(cuda_repository_package, "wb") as f: | ||
| f.write(r.read()) |
There was a problem hiding this comment.
For those looking -- this is the only change to remove the requests package
There was a problem hiding this comment.
urlopen(...) will raise when there are protocol errors -- just like r.raise_for_status() did
There was a problem hiding this comment.
Just a quick suggestion here: I don't know exactly what the size of the package is; however, caution should be taken with r.read() for large files, as this can consume a significant amount of host memory.
There was a problem hiding this comment.
hmm... true it is pulling the whole deb package. Lemme fix that
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the inclusion of the
requestslibrary drew inurllib3whose latests versions caused issues in charms which didn't havehatching.Update this library to not depend on
requestsat all