api: reduce code duplication

julelang · Jan 26, 2025 · e29ae07 · e29ae07
1 parent ff8b05a
commit e29ae07
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/api/builtin.hpp b/api/builtin.hpp
@@ -77,16 +77,9 @@ namespace jule
 
     // Common template for the append function variants.
     template <typename Dest, typename Components>
-    Dest __append(Dest dest, const Components &components)
+    inline Dest __append(Dest dest, const Components &components)
     {
-        if (components._len == 0)
-            return dest;
-        dest.alloc_for_append(components._len);
-        std::copy(
-            components._slice,
-            components._slice + components._len,
-            dest._slice + dest._len);
-        dest._len += components._len;
+        dest.append(components);
         return dest;
     }
 

diff --git a/api/slice.hpp b/api/slice.hpp
@@ -353,6 +353,8 @@ namespace jule
         template <typename Items>
         void append(const Items &items)
         {
+            if (items._len == 0)
+                return;
             this->alloc_for_append(items._len);
             std::copy(items._slice, items._slice + items._len, this->_slice + this->_len);
             this->_len += items._len;