Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sweep: Add a FIXME to wherever we explicitly mention julep-ai/samantha-1-turbo model in the agents-api/ directory #200

Closed
wants to merge 2 commits into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Apr 17, 2024

PR Feedback (click)

  • 👍 Sweep Did Well
  • 👎 Sweep Needs Improvement

Description

This pull request introduces a FIXME comment in two specific locations within the agents-api/ directory where the model identifier julep-ai/samantha-1-turbo is hard-coded. The purpose of these comments is to flag these instances for future review and potential refactoring to allow for dynamic configuration of the model identifier, enhancing the flexibility and maintainability of the codebase.

Summary

  • Added a FIXME comment in agents_api/activities/mem_rating.py to highlight the hard-coded model reference within the run_prompt function.
  • Inserted a FIXME comment in agents_api/models/agent/create_agent.py to draw attention to the hard-coded model reference in the default parameters for creating an agent.
  • These changes aim to flag areas where the codebase could benefit from increased configurability and reduce reliance on hard-coded values.
  • Affected files: agents_api/activities/mem_rating.py, agents_api/models/agent/create_agent.py.
  • Target directory for these changes is agents-api/.

Fixes #199.


🎉 Latest improvements to Sweep:
  • New dashboard launched for real-time tracking of Sweep issues, covering all stages from search to coding.
  • Integration of OpenAI's latest Assistant API for more efficient and reliable code planning and editing, improving speed by 3x.
  • Use the GitHub issues extension for creating Sweep issues directly from your editor.

💡 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

This is an automated message generated by Sweep AI.

Copy link
Contributor Author

sweep-ai bot commented Apr 17, 2024

Rollback Files For Sweep

  • Rollback changes to agents-api/agents_api/activities/mem_rating.py
  • Rollback changes to agents-api/agents_api/models/agent/create_agent.py

This is an automated message generated by Sweep AI.

@sweep-ai sweep-ai bot added the sweep Sweep your software chores label Apr 17, 2024
@creatorrr creatorrr closed this Apr 17, 2024
@creatorrr creatorrr deleted the sweep/add_a_fixme_to_wherever_we_explicitly_me branch April 17, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Sweep your software chores
Projects
None yet
1 participant