Convert api calls and integrations to tools #833
Conversation
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 193c764 in 1 minute and 27 seconds
More details
- Looked at
200lines of code in3files - Skipped
0files when reviewing. - Skipped posting
2drafted comments based on config settings.
1. agents-api/tests/test_activities_utils.py:16
- Draft comment:
The test usesDummyIntegrationDef, which is commented out inget_integration_arguments. This will always return an empty properties dictionary, potentially not testing the intended behavior. - Reason this comment was not posted:
Comment was on unchanged code.
2. agents-api/agents_api/activities/utils.py:469
- Draft comment:
Ensureintegration_argsis a Pydantic model before accessingmodel_fields. Otherwise, this will raise an error ifintegration_argsis not a Pydantic model. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_xSdAhlVvHFTRzZOu
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 4e6eb22 in 33 seconds
More details
- Looked at
652lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. agents-api/agents_api/activities/utils.py:574
- Draft comment:
fld_annotation.is_required()should befld_annotation.is_required.is_requiredis a property, not a method. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_hzvmd3SFzN1DFHGn
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
whiterabbit1983
force-pushed
the
f/api-call-integration-tools
branch
from
4e6eb22 to
1e41ca5
Compare
Signed-off-by: Diwank Singh Tomer <[email protected]>
There was a problem hiding this comment.
❌ Changes requested. Incremental review on 0c8b30a in 26 seconds
More details
- Looked at
74lines of code in3files - Skipped
0files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_lXaFOmJXq8cQ5REZ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| @@ -255,6 +255,7 @@ model FunctionCallOption { | |||
|
|
|||
| model NamedToolChoice { | |||
| function?: FunctionCallOption; | |||
| // TODO: Add integration, system, api_call | |||
There was a problem hiding this comment.
Consider updating the NamedToolChoice model to support integration, system, and api_call instead of marking them as never. This aligns with the PR's intent to support these tool types.
| @@ -288,6 +289,7 @@ | |||
| type: ToolType; | |||
|
|
|||
| function?: FunctionCallOption; | |||
| // TODO: Add integration, system, api_call | |||
There was a problem hiding this comment.
Consider updating the BaseChosenToolCall model to properly define integration, system, and api_call instead of marking them as unknown. This aligns with the PR's intent to support these tool types.
| // TODO: Add integration, system, api_call | |
| integration?: ChosenIntegrationCall; |
| @@ -437,7 +437,7 @@ async def run( | |||
| ]["type"] == "integration": | |||
| workflow.logger.debug("Prompt step: Received INTEGRATION tool call") | |||
|
|
|||
| # FIXME: Implement integration tool calls | |||
| # TODO: Implement integration tool calls | |||
There was a problem hiding this comment.
@whiterabbit1983 we need to implement these 3 blocks as well, refer to the ToolStep(...) for how to do them
Important
Convert API calls and integrations to tools by updating
format_tooland addingget_integration_arguments, with tests for integration argument mapping.format_toolinprompt_step.pynow supportsintegrationandapi_calltools by setting their parameters usingget_integration_argumentsandtool.api_call.schema_respectively.get_integration_argumentsinutils.pyto map integration providers to argument types and return their JSON schema.test_activities_utils.pyto testget_integration_argumentswith various integration definitions, ensuring correct schema generation.This description was created by
for 0c8b30a. It will automatically update as commits are pushed.